[webkit-reviews] review requested: [Bug 31293] Web Inspector: Enable 'console.profile()' and 'console.profileEnd()' regardless of JAVASCRIPT_DEBUGGER : [Attachment 43146] fixed argument conversion in JSC binding

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 13 01:01:54 PST 2009


Mikhail Naganov <mnaganov at chromium.org> has asked  for review:
Bug 31293: Web Inspector: Enable 'console.profile()' and 'console.profileEnd()'
regardless of JAVASCRIPT_DEBUGGER
https://bugs.webkit.org/show_bug.cgi?id=31293

Attachment 43146: fixed argument conversion in JSC binding
https://bugs.webkit.org/attachment.cgi?id=43146&action=review

------- Additional Comments from Mikhail Naganov <mnaganov at chromium.org>
I think 'console dir' test crash is completely unrelated. I ran 'inspector'
tests for several times w/o any troubles.

I fixed arguments conversion in JSC binding. As for V8, it currently doesn't
afford an ability to tag profiles with custom labels.


More information about the webkit-reviews mailing list