[webkit-reviews] review granted: [Bug 31451] LocalStorage quota should include key sizes in its count : [Attachment 43129] Patch

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 31451: LocalStorage quota should include key sizes in its count
https://bugs.webkit.org/show_bug.cgi?id=31451

Attachment 43129: Patch
https://bugs.webkit.org/attachment.cgi?id=43129&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
> +    unsigned adjustedKeyLength = oldValue.isNull() ? key.length() : 0;
> +    newLength += adjustedKeyLength;
> +    overflow |= (newLength > m_currentLength) != (value.length() +
adjustedKeyLength > oldValue.length());

I think the last line could be simply:
overflow |= newLength < m_currentLength;

r=me