[webkit-reviews] review requested: [Bug 30960] [CAIRO] shadow support for Canvas and SVG : [Attachment 43089] Update patch for Simon Fraser and Eric Seidel's comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 12 12:14:45 PST 2009


Brent Fulgham <bfulgham at webkit.org> has asked  for review:
Bug 30960: [CAIRO] shadow support for Canvas and SVG
https://bugs.webkit.org/show_bug.cgi?id=30960

Attachment 43089: Update patch for Simon Fraser and Eric Seidel's comments.
https://bugs.webkit.org/attachment.cgi?id=43089&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
Updated original patch:
1.  Updated to build with new ColorSpace data types.
2.  Revised const values per Simon's comments.
3.  Clarified HTML5 comment regarding origins of the shadow calculation.
4.  Renamed GraphicsContextFilter as "ImageBufferFilter", since that more
accurately describes its function.
5.  Included the VS project changes in the patch.


More information about the webkit-reviews mailing list