[webkit-reviews] review denied: [Bug 31352] [GTK] Failing test media/video-document-types.html : [Attachment 42962] Set document to parsing mode before parsing more data.

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 31352: [GTK] Failing test media/video-document-types.html
https://bugs.webkit.org/show_bug.cgi?id=31352

Attachment 42962: Set document to parsing mode before parsing more data.
https://bugs.webkit.org/attachment.cgi?id=42962&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
>	   FrameLoader* frameLoader = loader->frameLoader();
>	   frameLoader->setEncoding(encoding, userChosen);
> -	   if (data)
> +	   if (data) {
> +	       frameLoader->frame()->document()->setParsing(true);
>	       frameLoader->addData(data, length);
> +	       frameLoader->frame()->document()->setParsing(false);
> +	   }
>      }

This crash seems to be caused by the MediaDocument stopping parsing
prematurely:

bool MediaTokenizer::writeRawData(const char*, int)
{
    ASSERT(!m_mediaElement);
    if (m_mediaElement)
	return false;
	
    createDocumentStructure();
    finish();
    return false;
}
    
[...]
    
void MediaTokenizer::finish()
{
    if (!m_parserStopped) 
	m_doc->finishedParsing();
}

I wonder why this is done like this. Maybe Mac and Win are delegating the
loading of the video to something else? Anyway, since this is only a problem
with Media documents, I think what the patch is doing is fairly certainly
hiding a different issue, so r-.