[webkit-reviews] review requested: [Bug 30997] [Gtk] Implement AtkDocument's attribute support : [Attachment 43069] Layout Test - Take 3

[bugzilla-daemon at webkit.org]

Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 30997: [Gtk] Implement AtkDocument's attribute support
https://bugs.webkit.org/show_bug.cgi?id=30997

Attachment 43069: Layout Test - Take 3
https://bugs.webkit.org/attachment.cgi?id=43069&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
Thanks for the review! Hopefully third time will be charm. :-)

> The layout tests changes are missing a Changelog.

Added.

> > +	 AtkDocument* axDocument = ATK_DOCUMENT(m_element);
> > +	 return
JSStringCreateWithUTF8CString(atk_document_get_attribute_value(axDocument,
"Encoding"));
> 
> No need for axDocument here. I think you can just pass it to
> atk_document_get_attribute_value directly.

Done.

> > +	 AtkDocument* axDocument = ATK_DOCUMENT(m_element);
> > +	 return
JSStringCreateWithUTF8CString(atk_document_get_attribute_value(axDocument,
"URI"));
> 
> Ditto.

Ditto. :-)