[webkit-reviews] review granted: [Bug 31393] externalRepresentation should take Frame as the argument : [Attachment 43036] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 31393: externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393

Attachment 43036: Patch v1
https://bugs.webkit.org/attachment.cgi?id=43036&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is a good change. But you're missing an opportunity to fix a major bug in
externalRepresentation.

The layout needs to be moved to the top of the function, before the SVG call to
writeRenderResources.

And the RenderObject should be fetched only after the call to layout.

I'll say r=me assuming that you'll do those fixes in a subsequent patch,
because those are really the motivation for making this change.