[webkit-reviews] review granted: [Bug 31186] Cleanup: Rename fields RenderTextControl::m_edited and RenderTextControl::m_userEdited : [Attachment 43020] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 31186: Cleanup: Rename fields RenderTextControl::m_edited and
RenderTextControl::m_userEdited
https://bugs.webkit.org/show_bug.cgi?id=31186

Attachment 43020: Patch
https://bugs.webkit.org/attachment.cgi?id=43020&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -	   // We set m_userEdited to false since this change was not explicty
made by the user (say, via typing on the keyboard), see
<rdar://problem/5359921>.
> -	   m_userEdited = false;
> +	   // We set m_lastChangeWasUserEdit to false since this change was not
explicty made by the user (say, via typing on the keyboard), see
<rdar://problem/5359921>.
> +	   m_lastChangeWasUserEdit = false;

It would be nice to fix the spelling of explicitly.

I don't think the "see rdar" comment is really all that useful, even for people
at Apple.

I think the comment is no longer needed; the new name of the data member speaks
for itself. Or if we really want one, the comment could say, "Set
m_lastChangeWasUserEdit to false since this function is only used for
programmatic changes, not for user editing."

As you mentioned, we should make other changes here. We don't want people to
directly set these with set functions.