[webkit-reviews] review denied: [Bug 30997] [Gtk] Implement AtkDocument's attribute support : [Attachment 42317] Layout Test - Take 2

[bugzilla-daemon at webkit.org]

Jan Alonzo <jmalonzo at gmail.com> has denied Joanmarie Diggs
<joanmarie.diggs at gmail.com>'s request for review:
Bug 30997: [Gtk] Implement AtkDocument's attribute support
https://bugs.webkit.org/show_bug.cgi?id=30997

Attachment 42317: Layout Test - Take 2
https://bugs.webkit.org/attachment.cgi?id=42317&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
>  LayoutTests/platform/mac/Skipped		      |    3 +++
>  LayoutTests/platform/win/Skipped		      |    1 +
>  WebKitTools/ChangeLog			      |   20
++++++++++++++++++++
>  .../DumpRenderTree/AccessibilityUIElement.cpp      |   14 ++++++++++++++
>  .../DumpRenderTree/AccessibilityUIElement.h	      |    2 ++
>  .../gtk/AccessibilityUIElementGtk.cpp	      |   20
++++++++++++++++++++
>  .../mac/AccessibilityUIElementMac.mm 	      |   10 ++++++++++
>  .../win/AccessibilityUIElementWin.cpp	      |   11 +++++++++++
>  8 files changed, 81 insertions(+), 0 deletions(-)

The layout tests changes are missing a Changelog.

> +
> +    AtkDocument* axDocument = ATK_DOCUMENT(m_element);
> +    return
JSStringCreateWithUTF8CString(atk_document_get_attribute_value(axDocument,
"Encoding"));

No need for axDocument here. I think you can just pass it to
atk_document_get_attribute_value directly.

> +}
> +
> +JSStringRef AccessibilityUIElement::documentURI()
> +{
> +    AtkRole role = atk_object_get_role(ATK_OBJECT(m_element));
> +    if (role != ATK_ROLE_DOCUMENT_FRAME)
> +	   return JSStringCreateWithCharacters(0, 0);
> +
> +    AtkDocument* axDocument = ATK_DOCUMENT(m_element);
> +    return
JSStringCreateWithUTF8CString(atk_document_get_attribute_value(axDocument,
"URI"));

Ditto.

Patch looks good. But I'm going to say r- because of the missing Changelog for
the layout test changes.