[webkit-reviews] review requested: [Bug 26310] Webkit should generate "compositionstart", "compositionend", and "text" events like firefox : [Attachment 43031] proposed patch 4 (for WebKit and Chromium)

[bugzilla-daemon at webkit.org]

Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 26310: Webkit should generate "compositionstart", "compositionend", and
"text" events like firefox
https://bugs.webkit.org/show_bug.cgi?id=26310

Attachment 43031: proposed patch 4 (for WebKit and Chromium)
https://bugs.webkit.org/attachment.cgi?id=43031&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Hi Eric,

Thank you so much for your review, and sorry for this build failure caused by
my change.
I noticed the xcode project file in my previous change always refers to
"WebKitBuild/Release/DerivedSources/WebCore/JSCompositionEvent.cpp" and it
causes a build break when we build the debug version without building the
release version. (This is a bonehead mistake of mine in adding
JSCompositionEvent.{cpp,h} to this project.)
To fix this problem, I have changed the project file, and confirmed I can
compile the debug version without building the release one.
(Except this change, this patch is same as the previous one.)
Would it be possible to review the update one?

Regards,

Hironori Bono