[webkit-reviews] review denied: [Bug 31388] Fix the ref-counting bug in Database.cpp : [Attachment 43024] patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 31388: Fix the ref-counting bug in Database.cpp
https://bugs.webkit.org/show_bug.cgi?id=31388

Attachment 43024: patch
https://bugs.webkit.org/attachment.cgi?id=43024&action=review

------- Additional Comments from David Levin <levin at chromium.org>
r- for no explanation of fix in change log (and it looks equivalent to me,
sorry that I don't see it).


> Index: WebCore/ChangeLog
> +2009-11-11  Dumitru Daniliuc  <dumi at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Database.cpp does not correctly handle ref-counting in
> +	Database::openDatabase().

Please remove the TAB here.

Also please explain the bug that is fixed. The code looks equivalent to me.


> Index: WebCore/storage/Database.cpp
> +PassRefPtr<Database> Database::create(Document* document, const String&
name, const String& expectedVersion, const String& displayName, unsigned long
estimatedSize) {

The open brace for the function needs to go on the next line.


> Index: WebCore/storage/Database.h
> +    static PassRefPtr<Database> create(Document* document, const String&
name, const String& expectedVersion, const String& displayName, unsigned long
estimatedSize);

The param name "document" shouldn't be here.