[webkit-reviews] review requested: [Bug 31186] Cleanup: Rename fields RenderTextControl::m_edited and RenderTextControl::m_userEdited : [Attachment 43020] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 31186: Cleanup: Rename fields RenderTextControl::m_edited and
RenderTextControl::m_userEdited
https://bugs.webkit.org/show_bug.cgi?id=31186

Attachment 43020: Patch
https://bugs.webkit.org/attachment.cgi?id=43020&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
No functionality was changed so no tests were included in this patch.

On Darin's suggestion <https://bugs.webkit.org/show_bug.cgi?id=20780#c24>, I
chose to rename RenderTextControl::m_edited to wasChangedSinceLastChangeEvent,
and RenderTextControl::m_userEdited to m_lastChangeWasUserEdit. I felt these
names were consistent (in wording - both use the word "change" to describe the
modification to the text control) and best described what these fields are for.
It would have been nice if we could have more concise names for these fields,
but I could not think of any.

We should probably look into re-factoring the functionality of these
methods/cleanup RenderTextControl as outlined in
<https://bugs.webkit.org/show_bug.cgi?id=20780#c14>. Then we may have a cleaner
API.