[webkit-reviews] review requested: [Bug 31382] Make -webkit-color-correction work with shadows : [Attachment 43015] Patch

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 31382: Make -webkit-color-correction work with shadows
https://bugs.webkit.org/show_bug.cgi?id=31382

Attachment 43015: Patch
https://bugs.webkit.org/attachment.cgi?id=43015&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
A few things about this patch:

1. As I mention in the Changelog, this doesn't fix canvas shadows. I will fix
those when I fix canvas <https://bugs.webkit.org/show_bug.cgi?id=31319>
2. I did not make a new variable on the state for the shadow ColorSpace. This
is not necessary with the way things are currently implemented. Furthermore, I
realized that it is probably silly to have both a strokeColorSpace and a
fillColorSpace -- I am pretty certain that even when the colors are different,
stroke and fill will have the same ColorSpace, right? Anyway, it seems like
these could be collapsed into one variable. I did not do that with the patch,
but I am considering it. Maybe now or maybe later, what do you think?