[webkit-reviews] review granted: [Bug 31363] fast/css/color-correction tests crash on Windows : [Attachment 43006] WebCore Workaround + Skipped List Removal

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 31363: fast/css/color-correction tests crash on Windows
https://bugs.webkit.org/show_bug.cgi?id=31363

Attachment 43006: WebCore Workaround + Skipped List Removal
https://bugs.webkit.org/attachment.cgi?id=43006&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
> +#if PLATFORM(WIN)
> +    return deviceRGBColorSpaceRef();
> +#else
>  #ifdef BUILDING_ON_TIGER
>      return deviceRGBColorSpaceRef();
>  #else
>      static CGColorSpaceRef sRGBSpace =
CGColorSpaceCreateWithName(kCGColorSpaceSRGB);
>      return sRGBSpace;
>  #endif
> +#endif
>  }

I think you can re-write this as:

#if PLATORM(WIN) || DEFINED(BUILDING_ON_TIGER)
   return deviceRGBColorSpaceRef();
#else
      static CGColorSpaceRef sRGBSpace =
CGColorSpaceCreateWithName(kCGColorSpaceSRGB);
      return sRGBSpace;
#endif

which might be a little neater, but it's up to you.