[webkit-reviews] review denied: [Bug 31266] [Qt] QWebSettings::setMaximumPagesInCache(int pages) does not enable the Page Cache : [Attachment 42961] proposed patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Andras Becsi
<becsi.andras at stud.u-szeged.hu>'s request for review:
Bug 31266: [Qt] QWebSettings::setMaximumPagesInCache(int pages) does not enable
the Page Cache
https://bugs.webkit.org/show_bug.cgi?id=31266

Attachment 42961: proposed patch
https://bugs.webkit.org/attachment.cgi?id=42961&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r- due to the earlier comments. For now we should enable/disable the cache only
depending on the maximumPagesInCache value, i.e. the cache capacity.