[webkit-reviews] review denied: [Bug 31344] [Qt] Fix a problem in the qmake project files that caused nmake to reparse idl files every time. : [Attachment 42947] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 31344: [Qt] Fix a problem in the qmake project files that caused nmake to
reparse idl files every time.
https://bugs.webkit.org/show_bug.cgi?id=31344

Attachment 42947: Patch
https://bugs.webkit.org/attachment.cgi?id=42947&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Hmm, I see the problem. But this will break parallel builds, where make will
execute the same command in parallel to generate both files at the same time:

If Foo.idl is processed by $cmd to generate Foo.cpp and Foo.h at the same time,
then with this patch and a parallel build $cmd is executed twice and both
processes will race for generating the two files.