[webkit-reviews] review granted: [Bug 31195] File upload control shows a single filename even if multiple files are selected : [Attachment 42915] DRT change for RenderFileUploadControl (rev.3)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 11 12:49:21 PST 2009


Darin Adler <darin at apple.com> has granted TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 31195: File upload control shows a single filename even if multiple files
are selected
https://bugs.webkit.org/show_bug.cgi?id=31195

Attachment 42915: DRT change for RenderFileUploadControl (rev.3)
https://bugs.webkit.org/attachment.cgi?id=42915&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   if (o.isFileUploadControl()) {
> +	       ts << " " <<
quoteAndEscapeNonPrintables(toRenderFileUploadControl(&o)->fileTextValue());
> +	   }

One line if statements should not have braces.

r=me, that's minor


More information about the webkit-reviews mailing list