[webkit-reviews] review denied: [Bug 31361] WebInspector: Tests for Layout, Paint, ParseHTML, MarkTimeline, Style Recalculation : [Attachment 42979] WebInspector: Adds Timeline record tests for Layout, Paint, Recalculate Style, Parse HTML and Mark Timeline
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 11 11:13:32 PST 2009
Pavel Feldman <pfeldman at chromium.org> has denied Eric Ayers
<zundel at google.com>'s request for review:
Bug 31361: WebInspector: Tests for Layout, Paint, ParseHTML, MarkTimeline,
Style Recalculation
https://bugs.webkit.org/show_bug.cgi?id=31361
Attachment 42979: WebInspector: Adds Timeline record tests for Layout, Paint,
Recalculate Style, Parse HTML and Mark Timeline
https://bugs.webkit.org/attachment.cgi?id=42979&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> + if (record.type == timelineAgentRecordType.Layout) {
Please use ===
> + if (record.type == timelineAgentRecordType.MarkTimeline &&
record.data.message == timelineMark) {
ditto
> + if (found =findMarkTimeline(record))
space after =
> + if (record.type == timelineAgentRecordType.Paint) {
ditto
> + if (record.type == timelineAgentRecordType.ParseHTML) {
ditto
> + if (record.type == timelineAgentRecordType.RecalculateStyles) {
ditto
r- for style, rest seems to be fine.
More information about the webkit-reviews
mailing list