[webkit-reviews] review denied: [Bug 30898] Browser crash by deeply nested elements : [Attachment 42940] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 11 10:48:21 PST 2009


Dave Hyatt <hyatt at apple.com> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 30898: Browser crash by deeply nested elements
https://bugs.webkit.org/show_bug.cgi?id=30898

Attachment 42940: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=42940&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Your ChangeLog comment says 4096, but then your #define is 8192.

Your ifdef is in Node, but if you're really talking about renderobject depth
limiting and not DOM limiting, then it should be over in RenderObject files.

You cannot add a field to RenderObject.  That's not an acceptable memory hit to
take.


More information about the webkit-reviews mailing list