[webkit-reviews] review requested: [Bug 31266] [Qt] QWebSettings::setMaximumPagesInCache(int pages) does not enable the Page Cache : [Attachment 42961] proposed patch

[bugzilla-daemon at webkit.org]

Andras Becsi <becsi.andras at stud.u-szeged.hu> has asked	for review:
Bug 31266: [Qt] QWebSettings::setMaximumPagesInCache(int pages) does not enable
the Page Cache
https://bugs.webkit.org/show_bug.cgi?id=31266

Attachment 42961: proposed patch
https://bugs.webkit.org/attachment.cgi?id=42961&action=review

------- Additional Comments from Andras Becsi <becsi.andras at stud.u-szeged.hu>
Without adding a new QWebSetting enum value it did not enable the global cache,
so I needed to add one, but there are no new functions so no API change.
There are two known tests which are skipped because of Page Cache. As
implemented they do not time-out and crash any more, but revealed another bug
which causes a JS console message:

"CONSOLE MESSAGE: ReferenceError: Trying to access object from destroyed
plug-in."

which is a different issue, and tonikitoo will hopefully comfirm that my patch
is actually making Page Cache to work.