[webkit-reviews] review denied: [Bug 25415] [GTK][ATK] Please implement support for get_text_at_offset : [Attachment 42544] Fix for the issue in comment 59

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 11 04:52:53 PST 2009


Xan Lopez <xan.lopez at gmail.com> has denied Joanmarie Diggs
<joanmarie.diggs at gmail.com>'s request for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 42544: Fix for the issue in comment 59
https://bugs.webkit.org/attachment.cgi?id=42544&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Can't you simply check if 'box' is not null to add the \n? I'm not 100% sure
nextOnLineExists does exactly what we want, since I'm not very familiar with
these APIs. It might we the right thing, but then we should be probably using
netxOnLine() instead of nextTextboxy()? If you feel like checking that in
detail feel free to do so, otherwise just check the value of box. r- for now.


More information about the webkit-reviews mailing list