[webkit-reviews] review canceled: [Bug 31168] Add [HintAtomic] to IDLs to remove unnecessary string conversions in generated V8 DOM bindings : [Attachment 42573] patch

[bugzilla-daemon at webkit.org]

Jens Alfke <snej at chromium.org> has canceled Jens Alfke <snej at chromium.org>'s
request for review:
Bug 31168: Add [HintAtomic] to IDLs to remove unnecessary string conversions in
generated V8 DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=31168

Attachment 42573: patch
https://bugs.webkit.org/attachment.cgi?id=42573&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
I've implemented what I described the other day:
- AtomicString.h adds the 'explicit' keyword to the AtomicString(String)
constructor, if NO_IMPLICIT_ATOMICSTRINGS is defined.
- DerivedSourcesAllInOne.cpp now #defines NO_IMPLICIT_ATOMICSTRINGS before
#Including any headers.
The result is that missing any [HintAtomic] annotations in the IDL now causes a
compile error.

I also had to add explicit AtomicString constructor calls to two headers that
are included indirectly by DerivedSourcesAllInOne, to keep them from failing to
compile in this new mode.