[webkit-reviews] review granted: [Bug 31312] Decouple authentication panel callbacks from ResourceHandle : [Attachment 42893] proposed patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Alexey Proskuryakov <ap at webkit.org>'s request for
review:
Bug 31312: Decouple authentication panel callbacks from ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=31312

Attachment 42893: proposed patch
https://bugs.webkit.org/attachment.cgi?id=42893&action=review

------- Additional Comments from mitz at webkit.org
> + * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
> + * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
> + */
> +#ifndef AuthenticationClient_h
> +#define AuthenticationClient_h

There should be an empty line before the #ifndef. Also, this is not the latest
version of the license Apple uses (see
<http://webkit.org/coding/bsd-license.html> and
<http://trac.webkit.org/browser/trunk/WebKit/mac/WebView/WebVideoFullscreenHUDW
indowController.h> for a comment-formatted version).

r=me