[webkit-reviews] review requested: [Bug 31265] Find a new home for setUseSecureKeyboardEntry (and Mac implementation) : [Attachment 42890] Incremental improvement, v2

[bugzilla-daemon at webkit.org]

Stuart Morgan <stuartmorgan at chromium.org> has asked  for review:
Bug 31265: Find a new home for setUseSecureKeyboardEntry (and Mac
implementation)
https://bugs.webkit.org/show_bug.cgi?id=31265

Attachment 42890: Incremental improvement, v2
https://bugs.webkit.org/attachment.cgi?id=42890&action=review

------- Additional Comments from Stuart Morgan <stuartmorgan at chromium.org>
Addresses review comments (sorry for the WebKit-n00b mistakes!)

Two questions:
- This uses the FrameMac.cpp copyright block used for the moved code (except
with the date changed to 2006, since as you said the code predates that file).
I've also noticed some hybrid copyrights that list both Apple, with one date,
and Google, with another, but wasn't sure when that was called for; since the
non-moved code here was negligible I asume it doesn't need that, but let me
know if there's a convention I should follow.
- Regarding the Carbon include, build-webkit --debug fails for me, choking on
all the Carbon symbols in that file, if I don't include it, so it does seem to
be necessary for PLATFORM(MAC). Is there something I have configured wrong?