[webkit-reviews] review denied: [Bug 31292] [Chromium][Linux] Support Gtk scrollwheel behavior on Linux Chromium : [Attachment 42863] Support Gtk scrollwheel behavior for horizontal scrollbars on Linux Chromium

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 10 13:10:46 PST 2009


Eric Seidel <eric at webkit.org> has denied Kinuko Yasuda <kinuko at google.com>'s
request for review:
Bug 31292: [Chromium][Linux] Support Gtk scrollwheel behavior on Linux Chromium
https://bugs.webkit.org/show_bug.cgi?id=31292

Attachment 42863: Support Gtk scrollwheel behavior for horizontal scrollbars on
Linux Chromium
https://bugs.webkit.org/attachment.cgi?id=42863&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Every change requires a ChangeLog.  See
http://webkit.org/coding/contributing.html

Otherwise looks fine.

the code comes
 160 // from gtk/EventHandlerGtk.cpp.

Sad we can't share more code with EventHanderGtk...

r- for lack of ChangeLog.


More information about the webkit-reviews mailing list