[webkit-reviews] review granted: [Bug 31301] [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726). : [Attachment 42874] patch:layout test and fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 10 10:26:04 PST 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Vitaly Repeshko
<vitalyr at chromium.org>'s request for review:
Bug 31301: [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
https://bugs.webkit.org/show_bug.cgi?id=31301

Attachment 42874: patch:layout test and fix
https://bugs.webkit.org/attachment.cgi?id=42874&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
>	   // XPath-related utilities
> -	   static RefPtr<XPathNSResolver>
getXPathNSResolver(v8::Handle<v8::Value> value)
> +	   static RefPtr<XPathNSResolver>
getXPathNSResolver(v8::Handle<v8::Value> value, V8Proxy* proxy=0)

proxy = 0

otherwise, r=me.


More information about the webkit-reviews mailing list