[webkit-reviews] review requested: [Bug 31281] r50665 broke around 100 Qt layout tests : [Attachment 42860] proposed patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has asked  for review:
Bug 31281: r50665 broke around 100 Qt layout tests
https://bugs.webkit.org/show_bug.cgi?id=31281

Attachment 42860: proposed patch
https://bugs.webkit.org/attachment.cgi?id=42860&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
FrameView::FrameView() set initial value of m_canHaveScrollbars(true), but
DumpRenderTree of Qt disable scrollbars by default:

WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp :
252	    m_page->mainFrame()->setScrollBarPolicy(Qt::Horizontal,
Qt::ScrollBarAlwaysOff);
253	    m_page->mainFrame()->setScrollBarPolicy(Qt::Vertical,
Qt::ScrollBarAlwaysOff);

If we call updateCanHaveScrollbars(), it makes QtBuildBot happy. :)

Only we have only one problem: The new fast/overflow/scrollbar-restored.html
won't work on Qt, because scrollbars are disabled by DumpRenderTree. After
resizing scrollbars won't be appear if it is disabled ...

Should we enable scrollbars? It would make some tests fail ...
Or should we skip only this new test?