[webkit-reviews] review granted: [Bug 31047] [GTK] Failing test media/video-played-ranges-1.html : [Attachment 42746] fix playback rate setter

[bugzilla-daemon at webkit.org]

Jan Alonzo <jmalonzo at gmail.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 31047: [GTK] Failing test media/video-played-ranges-1.html
https://bugs.webkit.org/show_bug.cgi?id=31047

Attachment 42746: fix playback rate setter
https://bugs.webkit.org/attachment.cgi?id=42746&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
r=me. I have a couple of minor suggestions though.

> +    // Position is available only if the pipeline is not in NULL or
> +    // READY state.
> +    if (position != GST_CLOCK_TIME_NONE)
> +	   ret = (float) (position / 1000000000.0);

We tend to avoid C-style casts and use static_cast and friends (also exists in
a couple of places in this patch).

> +    gst_element_get_state(m_playBin,
> +	   &state, &pending, 250 * GST_NSECOND);

And also we tend to not break into multiple lines where a one-liner would
suffice.

Other those it's ok.