[webkit-reviews] review requested: [Bug 31196] Implement -webkit-color-correction for CSS colors : [Attachment 42846] New Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 9 19:45:55 PST 2009


Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 31196: Implement -webkit-color-correction for CSS colors
https://bugs.webkit.org/show_bug.cgi?id=31196

Attachment 42846: New Patch
https://bugs.webkit.org/attachment.cgi?id=42846&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
New and improved patch! This patch fixes the leaks Simon found, is built on top
of the newly cleaned-up GraphicsContext, uses a single enum stored in it's own
header for CSS and GraphicsContext (platform/graphics/ColorSpace.h), requires
callers of GraphicsContext functions to provide ColorSpaces rather than
sneaking in using defaults (per Darin's request), and attempts to keep other
ports building.


More information about the webkit-reviews mailing list