[webkit-reviews] review granted: [Bug 31198] Can cache prototype lookups on uncacheable dictionaries. : [Attachment 42816] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 31198: Can cache prototype lookups on uncacheable dictionaries.
https://bugs.webkit.org/show_bug.cgi?id=31198

Attachment 42816: Patch
https://bugs.webkit.org/attachment.cgi?id=42816&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
I don't like the name sortedProperties, partly because in the first loop, it
isn't yet sorted, partly because it was not immediately clear to me these were
pointers into the original map (modified by the entry-> writes).

I'm not sure what a good name would be, so I think a couple more comments
(like, "These writes are modifying the persistent property map for the
structure!".  Or something.)

And the variable name 'p' is kinda sucky, too.

But the code all looks sensible, r+.