[webkit-reviews] review requested: [Bug 30901] [Gtk] Need to de-lint the Atk a11y code : [Attachment 42813] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 9 17:30:42 PST 2009


Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 30901: [Gtk] Need to de-lint the Atk a11y code
https://bugs.webkit.org/show_bug.cgi?id=30901

Attachment 42813: proposed patch
https://bugs.webkit.org/attachment.cgi?id=42813&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
Discovered a signed/unsigned comparison warning that I was responsible for. :-/
Seemed like a good excuse to de-lint... :-)

* NULL should be 0
* Caps in keeping with the style guidelines
* Remove trailing whitespace
* No space between the pointer type and the '*'
* Remove the aforementioned signed/unsigned comparison


More information about the webkit-reviews mailing list