[webkit-reviews] review requested: [Bug 31204] WebInspector: RR for unit test of timeline data : [Attachment 42798] WebInspector: Adds a unit test for Timeline records

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 9 14:00:16 PST 2009


Eric Ayers <zundel at google.com> has asked  for review:
Bug 31204: WebInspector: RR for unit test of timeline data
https://bugs.webkit.org/show_bug.cgi?id=31204

Attachment 42798: WebInspector: Adds a unit test for Timeline records
https://bugs.webkit.org/attachment.cgi?id=42798&action=review

------- Additional Comments from Eric Ayers <zundel at google.com>
Added a few changes since the last patch:

- Addressed braces style comment
- Added 'timeline' to name of all functions meant to be used in tests
- Changed the output of the test to only print the MarkTImeline node and its
ancestors.  Intended to make the test less brittle to changes not related to
the script tag
- Changed the output of the test to print the properties of the EvaluateScript
timeline record.  If there is a new property added or one removed, the test
will need to be updated.

Tested this patch with --iterations 100 on all scripts in the
LayoutTests/inspetor directory.


More information about the webkit-reviews mailing list