[webkit-reviews] review denied: [Bug 5861] feConvolveMatrix filter is not implemented : [Attachment 42717] SVG feConvolveMatrix implementation

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 5861: feConvolveMatrix filter is not implemented
https://bugs.webkit.org/show_bug.cgi?id=5861

Attachment 42717: SVG feConvolveMatrix implementation
https://bugs.webkit.org/attachment.cgi?id=42717&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I don't like the _foo names, i think it would be better if you did

foo = m_foo;

if (this->hasAttribute(SVGNames::divisorAttr) && _divisor == 0.f)

What happens if divisor is NaN ?

In the inner loop of FEConvolveMatrix::apply seems really horrifyingly
expensive -- at the very lesat i think the edge case checks should be hoisted
out of the main loop and done separately.