[webkit-reviews] review requested: [Bug 30926] Optimizations to Element::getAttribute : [Attachment 42795] patch with "if(Attribute*..." restored
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 9 13:24:20 PST 2009
Jens Alfke <snej at chromium.org> has asked for review:
Bug 30926: Optimizations to Element::getAttribute
https://bugs.webkit.org/show_bug.cgi?id=30926
Attachment 42795: patch with "if(Attribute*..." restored
https://bugs.webkit.org/attachment.cgi?id=42795&action=review
------- Additional Comments from Jens Alfke <snej at chromium.org>
Only change is to the previously discussed 'if' statement:
- if (Attribute* a = namedAttrMap->getAttributeItem(name,
shouldIgnoreAttributeCase(this)))
- return a->value();
+ if (Attribute* attribute = namedAttrMap->getAttributeItem(name,
ignoreCase))
+ return attribute->value();
More information about the webkit-reviews
mailing list