[webkit-reviews] review requested: [Bug 5578] WebKit does not support DOM Level 3 setIsId and isId : [Attachment 42779] fix performance issue; pass related test cases
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 9 12:26:11 PST 2009
Chang Shu <Chang.Shu at nokia.com> has asked for review:
Bug 5578: WebKit does not support DOM Level 3 setIsId and isId
https://bugs.webkit.org/show_bug.cgi?id=5578
Attachment 42779: fix performance issue; pass related test cases
https://bugs.webkit.org/attachment.cgi?id=42779&action=review
------- Additional Comments from Chang Shu <Chang.Shu at nokia.com>
The performance issue was resolved using inline function (Using Darin's
"trick").
Enabled all existing related test cases and made them pass except two cases due
to separate namespace issues.
Darin,
So far I see the existing test cases are pretty comprehensive so I just simply
updated the expected results and made them work. If you prefer creating new
test cases, I can copy them over to a new place. I just feel the test cases may
be duplicated.
Thanks!
More information about the webkit-reviews
mailing list