[webkit-reviews] review granted: [Bug 31212] showTree(CounterNode*) generates too little info and has too many spaces. : [Attachment 42762] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Carol Szabo <carol.szabo at nokia.com>'s
request for review:
Bug 31212: showTree(CounterNode*) generates too little info and has too many
spaces.
https://bugs.webkit.org/show_bug.cgi?id=31212

Attachment 42762: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=42762&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Heh, I would have said "counter" instead of "current" -- nouns work better than
adjectives for variable names.

And the best function for writing one or two characters is probably fputc
rather than fwrite.

And on reflection I would probably use things like "parent", "prev" and "next"
instead of "P", "PS" and "NS".

r=me as is though, no need to go over and over this!