[webkit-reviews] review denied: [Bug 30651] Crash when lot of nested tables are loaded : [Attachment 42735] Fix infinite mutual recursion

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 9 10:03:41 PST 2009


Darin Adler <darin at apple.com> has denied Hayato Ito <hayato at google.com>'s
request for review:
Bug 30651: Crash when lot of nested tables are loaded
https://bugs.webkit.org/show_bug.cgi?id=30651

Attachment 42735: Fix infinite mutual recursion
https://bugs.webkit.org/attachment.cgi?id=42735&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This will probably cause performance regression if it's not inlined. The
insertNode function is quite hot, and calling a function for tagPriorityOfNode
is probably going to make it too slow.

I'm just going to say review- because it seems easy to mark it inline.

I think all three of these functions should be marked inline and put at the top
of the file before calls to them.


More information about the webkit-reviews mailing list