[webkit-reviews] review denied: [Bug 31106] [Chromium] handle web fonts in a secure manner : [Attachment 42738] transcode_webfonts_by_ots_v7
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 9 08:18:28 PST 2009
David Levin <levin at chromium.org> has denied Yusuke Sato
<yusukes at chromium.org>'s request for review:
Bug 31106: [Chromium] handle web fonts in a secure manner
https://bugs.webkit.org/show_bug.cgi?id=31106
Attachment 42738: transcode_webfonts_by_ots_v7
https://bugs.webkit.org/attachment.cgi?id=42738&action=review
------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebCore/platform/graphics/chromium/FontCustomPlatformData.cpp
b/WebCore/platform/graphics/chromium/FontCustomPlatformData.cpp
Why did the the include move to the header file?
Just put it here as you like in your previous patch.
> diff --git a/WebCore/platform/graphics/chromium/FontCustomPlatformData.h
b/WebCore/platform/graphics/chromium/FontCustomPlatformData.h
> #include "FontRenderingMode.h"
> #include <wtf/Noncopyable.h>
>
> +#if ENABLE(OPENTYPE_SANITIZER)
Now that you have the ENABLE guards in the header file, you don't need them
around the include.
> +#include "OpenTypeSanitizer.h"
I don't understand why this include is here (instead of being in the cpp file
as in the previous patch).
> diff --git a/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp
b/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp
> diff --git a/WebCore/platform/graphics/mac/FontCustomPlatformData.h
b/WebCore/platform/graphics/mac/FontCustomPlatformData.h
Same comments about the #include file for these two files as well.
> diff --git a/WebCore/platform/graphics/opentype/OpenTypeSanitizer.cpp
b/WebCore/platform/graphics/opentype/OpenTypeSanitizer.cpp
> +
> +#include "OwnArrayPtr.h"
Include wtf files like this:
#include <wtf/OwnArrayPtr.h>
and put it after the other includes.
> +#include "SharedBuffer.h"
> +#include "opentype-sanitiser.h"
> +#include "ots-memory-stream.h"
> + if (!ots::Process(&output, reinterpret_cast<const uint8_t
*>(m_buffer->data()), m_buffer->size()))
No space after the unit8_t. "reinterpret_cast<const uint8_t*>("
More information about the webkit-reviews
mailing list