[webkit-reviews] review denied: [Bug 30628] [Qt] It is impossible to list the attributes of QWebElement : [Attachment 42749] Add a method to list the attributes for a given namespace
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 9 07:49:03 PST 2009
Tor Arne Vestbø <vestbo at webkit.org> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 30628: [Qt] It is impossible to list the attributes of QWebElement
https://bugs.webkit.org/show_bug.cgi?id=30628
Attachment 42749: Add a method to list the attributes for a given namespace
https://bugs.webkit.org/attachment.cgi?id=42749&action=review
------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
> +QStringList QWebElement::attributesName(const QString &namespaceUri) const
Should be attributeNames, names in plural.
The argument-name 'namespaceUri' is fine, that's what we use for
QWebElement::attributeNS()
More information about the webkit-reviews
mailing list