[webkit-reviews] review denied: [Bug 31066] [GTK] opening local files on win32 : [Attachment 42514] change setting of mime types on win os (2. try)

[bugzilla-daemon at webkit.org]

Jan Alonzo <jmalonzo at gmail.com> has denied Josip <josip at pisoj.com>'s request
for review:
Bug 31066: [GTK] opening local files on win32
https://bugs.webkit.org/show_bug.cgi?id=31066

Attachment 42514: change setting of mime types on win os (2. try)
https://bugs.webkit.org/attachment.cgi?id=42514&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> +    #if PLATFORM(WIN_OS)
> +   
response.setMimeType(g_content_type_get_mime_type(g_file_info_get_content_type(
info)));
> +    #else
>      response.setMimeType(g_file_info_get_content_type(info));
> +    #endif

Were there any issues running the tests in WebKit/gtk/tests? You should be able
to add a test for this issue in one of the unit tests in that directory.

Also, there shouldn't be a space before #if/#else/#endif. 

r- because of the extra spaces. It would be nice if we have test for this too.