[webkit-reviews] review denied: [Bug 31238] Web Inspector: Inspector should support copy() in the command line : [Attachment 42730] proposed patch 3

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 31238: Web Inspector: Inspector should support copy() in the command line
https://bugs.webkit.org/show_bug.cgi?id=31238

Attachment 42730: proposed patch 3
https://bugs.webkit.org/attachment.cgi?id=42730&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +    void copyText(const String& text);
> +
>      // Generic code called from custom implementations.
>      void highlight(long nodeId);

Please move copyText into the "Generic code called from custom
implementations." (under that comment).


> +    var inspectorCommandLineAPI = evalFunction.call(evalObject,
"window.console._inspectorCommandLineAPI = { \n\
> +	   $: function() { return document.getElementById.apply(document,
arguments) }, \n\
> +	   $$: function() { return document.querySelectorAll.apply(document,
arguments) }, \n\
> +	   $x: function(xpath, context) \n\
> +	   { \n\

I assume that the only change here is \n in the end (please confirm)?

r- for the copyText outside the injectedscript section, otherwise r+!