[webkit-reviews] review requested: [Bug 25415] [GTK][ATK] Please implement support for get_text_at_offset : [Attachment 42712] Fix for the issue in comment 41, 55

Sun Nov 8 02:36:48 PST 2009

Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 42712: Fix for the issue in comment 41, 55
https://bugs.webkit.org/attachment.cgi?id=42712&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
It turns out that the segfault would/will occur pretty frequently:

<body>
hello
world
</body>

is sufficient. What seems to be going on is the modification (corruption?) of
utf8String when there is at least one newline char in the source. When we
attempt to free the string, GtkLauncher reliably segfaults.

The attach patch solves the problem and doesn't seem to have any side effects
w.r.t. get_text_at_offset. Is there a reason the line in question needs to
remain?

Please review. Thanks!