[webkit-reviews] review denied: [Bug 29231] Compiler warnings in InspectorResource.h : [Attachment 42709] Remove addition with variables of enum type

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Martin Robinson
<martin.james.robinson at gmail.com>'s request for review:
Bug 29231: Compiler warnings in InspectorResource.h
https://bugs.webkit.org/show_bug.cgi?id=29231

Attachment 42709: Remove addition with variables of enum type
https://bugs.webkit.org/attachment.cgi?id=42709&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
I think that after you patch hasChange(NoChange) will always be true. Hence
resources will stop updating due to the guard expression in
InspectorResource::updateScriptObject.
I guess what you should do is:

- remove NoChange at all
- introduce inline hasChanges that could return m_change != 0
- replace hasChange(NoChange) call with hasChanges
- and roll back rest (non need to change numbers).