[webkit-reviews] review requested: [Bug 30754] Drags and Dragover events not in sync : [Attachment 42708] Patch 1 with test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 7 19:28:27 PST 2009


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 30754: Drags and Dragover events not in sync
https://bugs.webkit.org/show_bug.cgi?id=30754

Attachment 42708: Patch 1 with test case
https://bugs.webkit.org/attachment.cgi?id=42708&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Because of the changes made in Changeset 50566
<http://trac.webkit.org/changeset/50566>, I needed make more than a handful of
changes to the original patch.

Also, this patch corrects an issue where the drag event did not precede a
dragleave event when the drag operation is canceled. I modified
EventHandler::cancelDragAndDrop to fire the drag event before a dragleave under
this circumstance.


More information about the webkit-reviews mailing list