[webkit-reviews] review requested: [Bug 30623] [GTK] Enable DOM clipboard and drag-and-drop access : [Attachment 42703] Add DataObjectGtk and use it for GDK_SELECTION_PRIMARY (rev2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 7 13:43:00 PST 2009


Martin Robinson <martin.james.robinson at gmail.com> has asked  for review:
Bug 30623: [GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Attachment 42703: Add DataObjectGtk and use it for GDK_SELECTION_PRIMARY (rev2)
https://bugs.webkit.org/attachment.cgi?id=42703&action=review

------- Additional Comments from Martin Robinson
<martin.james.robinson at gmail.com>
Thank you for the review. I've attached a patch addressing some of your issues
you mentioned. In some places the need to call g_free(...) has been removed by
making the uriList a vector of KURLs. In one other, I have switched to using
GOwnPtr.

IMO, m_image and m_dragContext should be GRefPtr's instead of GOwnPtr's. If you
feel like this patch needs that, I can shift my focus to finally getting that
into WebKit ( https://bugs.webkit.org/show_bug.cgi?id=21599 ).


More information about the webkit-reviews mailing list