[webkit-reviews] review denied: [Bug 31212] showTree(CounterNode*) generates too little info and has too many spaces. : [Attachment 42671] Proposed Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Carol Szabo <carol.szabo at nokia.com>'s
request for review:
Bug 31212: showTree(CounterNode*) generates too little info and has too many
spaces.
https://bugs.webkit.org/show_bug.cgi?id=31212

Attachment 42671: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=42671&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is great!

> +	   fprintf(stderr, "0x%08X %s: %d %d P:0x%08X PS:0x%08X NS:0x%08X
R:0x%08X\n",
> +	       current, current->isReset() ? "reset" : "increment",
current->value(),
> +	       current->countInParent(), current->parent(),
current->previousSibling(),
> +	       current->nextSibling(), current->renderer());

This won't compile without warnings under gcc. The specifier %08X takes an
"unsigned" as its argument, but we are passing in a pointer. The most portable
way to do this is probably to use %p instead of 0x%08X. Other solutions involve
converting the type by adding a typecast.

review- because this will break the build