[webkit-reviews] review denied: [Bug 30623] [GTK] Enable DOM clipboard and drag-and-drop access : [Attachment 42550] Add DataObjectGtk and use it for GDK_SELECTION_PRIMARY

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied Martin Robinson
<martin.james.robinson at gmail.com>'s request for review:
Bug 30623: [GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623

Attachment 42550: Add DataObjectGtk and use it for GDK_SELECTION_PRIMARY
https://bugs.webkit.org/attachment.cgi?id=42550&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +	   gchar* path = g_filename_from_uri(uri.utf8().data(), NULL, NULL);
> +	   if (!path)
> +	       continue;

^^^leaks scheme...

Use GOwnPtr here...


> +
> +	   files.append(path);
> +	   g_free(path);

^^^ Are you sure you want to create the String from ASCII?


> +    GdkPixbuf* m_image;
> +    GdkDragContext* m_dragContext;


Use a GOwnPtr here... this gets rid of all the if () unref if () ref things..



.. I stopped here for now.