[webkit-reviews] review denied: [Bug 31047] [GTK] Failing test media/video-played-ranges-1.html : [Attachment 42640] don't pause pipeline if already paused, same for play()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Nov 7 00:54:56 PST 2009
Holger Freyther <zecke at selfish.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 31047: [GTK] Failing test media/video-played-ranges-1.html
https://bugs.webkit.org/show_bug.cgi?id=31047
Attachment 42640: don't pause pipeline if already paused, same for play()
https://bugs.webkit.org/attachment.cgi?id=42640&action=review
------- Additional Comments from Holger Freyther <zecke at selfish.org>
I'm really allergic to timeouts. First they will block the GUI thread and
second they will eventually fail. so increase problems instead of reducing
them. If GStreamer really has a problem setting the pipeline to play twice we
will have to introduce double states... The one WebKit wants the pipeline to be
in and then listening to the state-changed bus message to see how our pipeline
is doing... (e.g. we set it to play but the pipeline has a problem and we get
an error message)...
More information about the webkit-reviews
mailing list