[webkit-reviews] review denied: [Bug 31047] [GTK] Failing test media/video-played-ranges-1.html : [Attachment 42639] fix playback rate setter
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Nov 7 00:49:32 PST 2009
Holger Freyther <zecke at selfish.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 31047: [GTK] Failing test media/video-played-ranges-1.html
https://bugs.webkit.org/show_bug.cgi?id=31047
Attachment 42639: fix playback rate setter
https://bugs.webkit.org/attachment.cgi?id=42639&action=review
------- Additional Comments from Holger Freyther <zecke at selfish.org>
Could you please improve the ChangeLog? It should be a complete sentence and
should describe what and why you do it. E.g. "Fix playback rate setter by
remembering the rate was changed ..." I specially wonder what you try to
achieve with the gst_element_get_state calls as seeking might or might not take
longer than the XYZ * GST_MSECOND...
More information about the webkit-reviews
mailing list