[webkit-reviews] review requested: [Bug 31219] Clean up GraphicsContext's current concept of ColorSpace : [Attachment 42681] Patch

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 31219: Clean up GraphicsContext's current concept of ColorSpace
https://bugs.webkit.org/show_bug.cgi?id=31219

Attachment 42681: Patch
https://bugs.webkit.org/attachment.cgi?id=42681&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Darin is likely to be at least a little disappointed in this patch since it is
more conservative than some other options we discussed for this cleanup.
Specifically, Darin noticed that once we have a Pattern or Gradient on the
GraphicsContext, we keep a pointer to it forever. I wrote code that would get
rid of old Patterns and Gradients once something that is not a Pattern or
Gradient is set, but a bunch of canvas pattern tests failed. I haven't
investigated the failures closely enough to know whether or not clearing out
the pattern is an option or not. Ultimately, it seems like that is just a
bigger problem than we are trying to solve today, and I will file a follow-up
bug so we can take a look at it later.