[webkit-reviews] review granted: [Bug 30926] Optimizations to Element::getAttribute : [Attachment 42232] patch 4 with better optimization
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 6 16:47:09 PST 2009
Darin Adler <darin at apple.com> has granted Jens Alfke <snej at chromium.org>'s
request for review:
Bug 30926: Optimizations to Element::getAttribute
https://bugs.webkit.org/show_bug.cgi?id=30926
Attachment 42232: patch 4 with better optimization
https://bugs.webkit.org/attachment.cgi?id=42232&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + Attribute* attribute = namedAttrMap->getAttributeItem(name,
ignoreCase);
> + if (attribute)
> + return attribute->value();
You took the local variable definition out of the if. Why?
r=me
More information about the webkit-reviews
mailing list